1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
use atomicwrites::{AtomicFile, Error as AtomicError, OverwriteBehavior};
use core::{convert::TryInto, fmt};
use serde::{de::DeserializeOwned, Serialize};
use std::{
    fs,
    io::{Seek, Write},
    path::{Path, PathBuf},
};
use tracing::{error, info, warn};

/// Errors that can occur during edits to a settings file.
pub enum Error<S: EditableSetting> {
    /// An error occurred validating the settings file.
    Integrity(S::Error),
    /// An IO error occurred when writing to the settings file.
    Io(std::io::Error),
}

impl<S: EditableSetting> fmt::Debug for Error<S> {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        match self {
            Error::Integrity(err) => fmt::Formatter::debug_tuple(f, "Integrity")
                .field(err)
                .finish(),
            Error::Io(err) => fmt::Formatter::debug_tuple(f, "Io").field(err).finish(),
        }
    }
}

/// Same as Error, but carries the validated settings in the Io case.
enum ErrorInternal<S: EditableSetting> {
    Integrity(S::Error),
    Io(std::io::Error, S),
}

impl<S: EditableSetting> fmt::Debug for ErrorInternal<S> {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        match self {
            ErrorInternal::Integrity(err) => fmt::Formatter::debug_tuple(f, "Integrity")
                .field(err)
                .finish(),
            ErrorInternal::Io(err, _setting) => fmt::Formatter::debug_tuple(f, "Io")
                .field(err)
                .field(&"EditableSetting not required to impl Debug")
                .finish(),
        }
    }
}

pub enum Version {
    /// This was an old version of the settings file, so overwrite with the
    /// modern config.
    Old,
    /// Latest version of the settings file.
    Latest,
}

pub trait EditableSetting: Clone + Default {
    const FILENAME: &'static str;

    /// Please use this error sparingly, since we ideally want to preserve
    /// forwards compatibility for all migrations.  In particular, this
    /// error should be used to fail validation *of the original settings
    /// file* that cannot be caught with ordinary parsing, rather than used
    /// to signal errors that occurred during migrations.
    ///
    /// The best error type is Infallible.
    type Error: fmt::Debug;

    /// Into<Setting> is expected to migrate directly to the latest version,
    /// which can be implemented using "chaining".  The use of `Into` here
    /// rather than TryInto is intended (together with the expected use of
    /// chaining) to prevent migrations from invalidating old save files
    /// without warning; there should always be a non-failing migration path
    /// from the oldest to latest format (if the migration path fails, we can
    /// panic).
    type Legacy: Serialize + DeserializeOwned + Into<Self>;

    /// TryInto<(Version, Self)> is expected to migrate to the latest version
    /// from any older version, using "chaining" (see [super::banlist] for
    /// examples).
    ///
    /// From<Self> is intended to construct the latest version of the
    /// configuratino file from Self, which we use to save the config file
    /// on migration or modification.  Note that it should always be the
    /// case that if x is constructed from any of Self::clone, Self::default, or
    /// Setting::try_into, then Setting::try_from(Self::into(x)).is_ok() must be
    /// true!
    ///
    /// The error should be used to fail validation *of the original settings
    /// file* that cannot be caught with parsing.  If we can possibly avoid
    /// it, we should not create errors in valid settings files during
    /// migration, to ensure forwards compatibility.
    type Setting: Serialize
        + DeserializeOwned
        + TryInto<(Version, Self), Error = Self::Error>
        + From<Self>;

    fn load(data_dir: &Path) -> Self {
        let path = Self::get_path(data_dir);

        if let Ok(mut file) = fs::File::open(&path) {
            match ron::de::from_reader(&mut file)
                .map(|setting: Self::Setting| setting.try_into())
                .or_else(|orig_err| {
                    file.rewind()?;
                    ron::de::from_reader(file)
                         .map(|legacy| Ok((Version::Old, Self::Legacy::into(legacy))))
                         // When both legacy and non-legacy have parse errors, prioritize the
                         // non-legacy one, since we can't tell which one is "right" and legacy
                         // formats are simple, early, and uncommon enough that we expect
                         // few parse errors in those.
                         .or(Err(orig_err))
                })
                .map_err(|e| {
                    warn!(
                        ?e,
                        "Failed to parse setting file! Falling back to default and moving \
                         existing file to a .invalid"
                    );
                })
                .and_then(|inner| {
                    inner.map_err(|e| {
                        warn!(
                            ?e,
                            "Failed to parse setting file! Falling back to default and moving \
                             existing file to a .invalid"
                        );
                    })
                }) {
                Ok((version, mut settings)) => {
                    if matches!(version, Version::Old) {
                        // Old version, which means we either performed a migration or there was
                        // some needed update to the file.  If this is the case, we preemptively
                        // overwrite the settings file (not strictly needed, but useful for
                        // people who do manual editing).
                        info!("Settings were changed on load, updating file...");
                        // We don't care if we encountered an error on saving updates to a
                        // settings file that we just loaded (it's already logged and migrated).
                        // However, we should crash if it reported an integrity failure, since we
                        // supposedly just validated it.
                        if let Err(Error::Integrity(err)) = settings
                            .edit(data_dir, |_| Some(()))
                            .expect("Some always returns Some")
                            .1
                        {
                            panic!(
                                "The identity conversion from a validated settings file must
                                    always be valid, but we found an integrity error: {:?}",
                                err
                            );
                        }
                    }
                    settings
                },
                Err(()) => {
                    // Rename existing file to .invalid.ron
                    let mut new_path = path.with_extension("invalid.ron");

                    // If invalid path already exists append number
                    for i in 1.. {
                        if !new_path.exists() {
                            break;
                        }

                        warn!(
                            ?new_path,
                            "Path to move invalid settings exists, appending number"
                        );
                        new_path = path.with_extension(format!("invalid{}.ron", i));
                    }

                    warn!("Renaming invalid settings file to: {}", new_path.display());
                    if let Err(e) = fs::rename(&path, &new_path) {
                        warn!(?e, ?path, ?new_path, "Failed to rename settings file.");
                    }

                    create_and_save_default(&path)
                },
            }
        } else {
            create_and_save_default(&path)
        }
    }

    /// If the result of calling f is None, we return None (this constitutes an
    /// early return and lets us abandon the in-progress edit).  For
    /// example, this can be used to avoid adding a new ban entry if someone
    /// is already banned and the user didn't explicitly specify that they
    /// wanted to add a new ban record, even though it would be completely
    /// valid to attach one.
    ///
    /// Otherwise (the result of calling f was Some(r)), we always return
    /// Some((r, res)), where:
    ///
    /// If res is Ok(()), validation succeeded for the edited, and changes made
    /// inside the closure are applied both in memory (to self) and
    /// atomically on disk.
    ///
    /// Otherwise (res is Err(e)), some step in the edit process failed.
    /// Specifically:
    ///
    /// * If e is Integrity, validation failed and the settings were not
    ///   updated.
    /// * If e is Io, validation succeeded and the settings were updated in
    ///   memory, but they could not be saved to storage (and a warning was
    ///   logged). The reason we return an error even though the operation was
    ///   partially successful is so we can alert the player who ran the command
    ///   about the failure, as they will often be an administrator who can
    ///   usefully act upon that information.
    #[must_use]
    fn edit<R>(
        &mut self,
        data_dir: &Path,
        f: impl FnOnce(&mut Self) -> Option<R>,
    ) -> Option<(R, Result<(), Error<Self>>)> {
        let path = Self::get_path(data_dir);

        // First, edit a copy.
        let mut copy = self.clone();
        let r = f(&mut copy)?;
        // Validate integrity of the raw data before saving (by making sure that
        // converting to and from the Settings format still produces a valid
        // file).
        Some((r, match save_to_file(copy, &path) {
            Ok(new_settings) => {
                *self = new_settings;
                Ok(())
            },
            Err(ErrorInternal::Io(err, new_settings)) => {
                warn!("Failed to save setting: {:?}", err);
                *self = new_settings;
                Err(Error::Io(err))
            },
            Err(ErrorInternal::Integrity(err)) => Err(Error::Integrity(err)),
        }))
    }

    fn get_path(data_dir: &Path) -> PathBuf {
        let mut path = super::with_config_dir(data_dir);
        path.push(Self::FILENAME);
        path
    }
}

fn save_to_file<S: EditableSetting>(setting: S, path: &Path) -> Result<S, ErrorInternal<S>> {
    let raw: <S as EditableSetting>::Setting = setting.into();
    let ron = ron::ser::to_string_pretty(&raw, ron::ser::PrettyConfig::default())
        .expect("RON does not throw any parse errors during serialization to string.");
    // This has the side effect of validating the copy, meaning it's safe to save
    // the file.
    let (_, settings): (Version, S) = raw.try_into().map_err(ErrorInternal::Integrity)?;
    // Create dir if it doesn't exist
    if let Some(dir) = path.parent() {
        if let Err(err) = fs::create_dir_all(dir) {
            return Err(ErrorInternal::Io(err, settings));
        }
    }
    // Atomically write the validated string to the settings file.
    let atomic_file = AtomicFile::new(path, OverwriteBehavior::AllowOverwrite);
    match atomic_file.write(|file| file.write_all(ron.as_bytes())) {
        Ok(()) => Ok(settings),
        Err(AtomicError::Internal(err)) | Err(AtomicError::User(err)) => {
            Err(ErrorInternal::Io(err, settings))
        },
    }
}

fn create_and_save_default<S: EditableSetting>(path: &Path) -> S {
    let default = S::default();
    match save_to_file(default, path) {
        Ok(settings) => settings,
        Err(ErrorInternal::Io(e, settings)) => {
            error!(?e, "Failed to create default setting file!");
            settings
        },
        Err(ErrorInternal::Integrity(err)) => {
            panic!(
                "The default settings file must always be valid, but we found an integrity error: \
                 {:?}",
                err
            );
        },
    }
}